Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components/google-cloud): Update args and location of ForecastingPreprocessingOp and ForecastingValidationOp #6403

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

yzhaozh
Copy link
Contributor

@yzhaozh yzhaozh commented Aug 20, 2021

Update ForecastingPreprocessingOp and ForecastingValidationOp:

  • Move them from experimental/init.py to experimental/forecasting/init.py
  • Change args from kwargs to named args
  • ForecastingValidationOp method: add an arg validation_theme. It was required by the component but forgotten in previous pr.

/assign @SinaChavoshi
/assign @IronPan

@google-oss-robot
Copy link

Hi @yzhaozh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented Aug 20, 2021

/ok-to-test
/lgtm

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants