Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpu sample issues #627

Merged
merged 4 commits into from
Jan 5, 2019
Merged

Fix gpu sample issues #627

merged 4 commits into from
Jan 5, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jan 4, 2019 •
edited by jlewi
Loading

  • Remove extra comma from kubeflow-training-classification.py
  • Add gpu setting in notebook sample
  • Disable gpu by default to pass the sample test. Another PR is pending on gpu quota approval for test project.

This change is Reviewable

@hongye-sun
Copy link
Contributor Author

I accidentally close the previous PR. This PR is to fix the gpu sample issues. I will have another PR to enable sample test to cover gpu case.

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be42b56 into kubeflow:master Jan 5, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@dependabot @k8s-ci-robot
Bump pillow in /docs/samples/transformer/image_transformer (kubeflow#627
e6c13a1 
)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst)
- [Commits](python-pillow/Pillow@6.1.0...6.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@qimingj qimingj Awaiting requested review from qimingj

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongye-sun @gaoning777 @k8s-ci-robot