Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support replacable arguments in command as well (besides arguments) in container op. #623

Merged
merged 5 commits into from
Jan 7, 2019
Merged

Support replacable arguments in command as well (besides arguments) in container op. #623

merged 5 commits into from
Jan 7, 2019

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Jan 4, 2019 •
edited by IronPan
Loading

This change is Reviewable

@qimingj qimingj requested a review from Ark-kun January 4, 2019 22:28
Ark-kun
Ark-kun reviewed Jan 5, 2019
View reviewed changes
sdk/python/kfp/dsl/_container_op.py Outdated
if command:
to_search += command

for arg in to_search:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for arg in (command or []) + (arguments or []):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. PTAL

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 5, 2019

/lgtm

@Ark-kun Ark-kun mentioned this pull request Jan 5, 2019
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 7, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 7, 2019

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Jan 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 875efea into kubeflow:master Jan 7, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@sarahmaddox
Added gsoc label to kubeflow_label.yml (kubeflow#623)
998de3f 
* Added gsoc label to kubeflow_label.yml

* Changed label category to 'area'.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ScrapCodes
fix(pipelineLoop): Update to latest tekton release v0.25.0. (kubeflow…
078c742 
…#623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@Ark-kun Ark-kun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qimingj @Ark-kun @k8s-ci-robot