Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use argo v3.1.2-patch.2. Part of #5718 #6082

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jul 19, 2021

Description of your changes:
another patch that fixes emissary executor + non root + parameters + artifacts

Part of #5718

Note, this v3.1.2-patch.2 version is my forked argo: https://github.com/Bobgy/argo-workflows/tree/v3.1.2-patch.2.
It adds several patch fixes for nonroot containers on top of argo v3.1.2: https://github.com/Bobgy/argo-workflows/commits/v3.1.2-patch.2

Checklist:

@capri-xiyue
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 21, 2021

/hold
Not ready yet

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@Bobgy Bobgy changed the title feat: use argo v3.1.2-patch feat: use argo v3.1.2-patch.2 Jul 22, 2021
@Bobgy Bobgy changed the title feat: use argo v3.1.2-patch.2 feat: use argo v3.1.2-patch.2. Part of #5718 Jul 22, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/unhold
ready to merge

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Jul 22, 2021

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test
/test kubeflow-pipeline-upgrade-test
/test kubeflow-pipeline-mkp-test

@Bobgy Bobgy added the lgtm label Jul 22, 2021
@google-oss-robot google-oss-robot merged commit 0434243 into kubeflow:master Jul 22, 2021
@Bobgy Bobgy deleted the argo-v3.1.2-patch branch July 22, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants