Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve condition sample to demonstrate ==, >= and <. #607

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Improve condition sample to demonstrate ==, >= and <. #607

merged 2 commits into from
Jan 3, 2019

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Jan 3, 2019 •
edited by jlewi
Loading

This change is Reviewable

@qimingj qimingj requested review from Ark-kun and gaoning777 January 3, 2019 02:05
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 3, 2019

Are you sure you want to submit the binary?

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 3, 2019

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Jan 3, 2019

No. Not the binary. I will delete it. Thanks for catching it!

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 3, 2019
@qimingj
Copy link
Contributor Author

qimingj commented Jan 3, 2019

PTAL

@gaoning777
Copy link
Contributor

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Jan 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ead2757 into kubeflow:master Jan 3, 2019
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qimingj @Ark-kun @gaoning777 @k8s-ci-robot