Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Fixed the unittest script #556

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 17, 2018

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 18, 2018

/assign @gaoning777

@gaoning777
Copy link
Contributor

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor

can you take a look at the sample test failure?

@gaoning777
Copy link
Contributor

loos like a timeout error

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 22, 2018

@gaoning777 This script is not used by the tests. It's mostly for local development.

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 10, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 786544b into kubeflow:master Jan 10, 2019
@Ark-kun Ark-kun deleted the SDK---Fixed-the-unittest-script branch January 21, 2019 11:19
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants