Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: v2 sample test supports multiple test cases & internal endpoint #5432

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Apr 6, 2021

Description of your changes:
Changes:

  • v2 sample test supports multiple test cases -- many samples need more than one set of tests, either testing both v1 and v2 compatible versions, or testing multiple set of arguments, as shown in test: more samples in v2 sample test #5431
  • use internal endpoint for accessing KFP API server -- so that when errors happen, we can see the detailed error log (we preserve URLs as external links by passing in an extra parameter called external_host)

Checklist:

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 6, 2021

/retest

samples/test/util.py Outdated Show resolved Hide resolved
samples/test/util.py Outdated Show resolved Hide resolved
@neuromage
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 7, 2021

Thank you @neuromage!
I fixed the issues, would you want to confirm again?

@neuromage
Copy link
Contributor

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 7, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1128631 into kubeflow:master Apr 7, 2021
@Bobgy Bobgy deleted the v2-sample-test-refactor-2 branch April 7, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants