fix(backend): api server panics on workflow with parameter without value. Fixes #5423 #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @NikeNano @capri-xiyue |
|
/retest |
NikeNano
reviewed
Apr 3, 2021
Comment on lines
+198
to
+202
| {Name: "PARAM1", Value: workflowapi.AnyStringPtr("VALUE1")}, | ||
| {Name: "PARAM2", Value: workflowapi.AnyStringPtr("VALUE2")}, | ||
| {Name: "PARAM3", Value: workflowapi.AnyStringPtr("VALUE3")}, | ||
| {Name: "PARAM4", Value: workflowapi.AnyStringPtr("")}, | ||
| {Name: "PARAM5", Value: workflowapi.AnyStringPtr("VALUE5")}, |
There was a problem hiding this comment.
nit: does it add anything to have to have all these cases or could re remove PARAM1 and PARAM2
There was a problem hiding this comment.
It's better to have cases that have focused goals. When they fail, it's easier to find out why.
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
added a commit
to kubeflow/testing
that referenced
this pull request
Apr 6, 2021
Bobgy
added a commit
to kubeflow/testing
that referenced
this pull request
Apr 6, 2021
* test: upgrade kfp to 1.5.0-rc.2 * test: apply fix of kubeflow/pipelines#5424
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fixes #5423
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.