-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure dataproc components #542
Restructure dataproc components #542
Conversation
/cc ironpan qimingj |
/lgtm |
.cloudbuild.yaml
Outdated
@@ -125,27 +125,27 @@ steps: | |||
# Build the Dataproc-based pipeline component images | |||
- name: 'gcr.io/cloud-builders/docker' | |||
entrypoint: '/bin/bash' | |||
args: ['-c', 'cd /workspace/components/dataproc/containers/analyze && ./build.sh -p $PROJECT_ID -t $COMMIT_SHA'] | |||
args: ['-c', 'cd /workspace/components/dataproc/analyze/src && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No /src
in these paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct. Done
Thanks for your effort in this restructuring! |
/lgtm |
/approve |
/cc @qimingj |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-pipeline-build-image |
This change is