SDK/Components - Added the ComponentStore #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @qimingj |
qimingj
reviewed
Dec 12, 2018
…aying the component was not found. Component name must be non-empty. Addressed PR feedback.
|
/test kubeflow-pipeline-build-image |
|
@qimingj I've addressed your feedback. |
qimingj
approved these changes
Dec 12, 2018
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
neuromage
pushed a commit
to neuromage/pipelines
that referenced
this pull request
Dec 22, 2018
…ow#519) * SDK/Components - Made component search locations configurable * Raise proper error on existing, but malformed components instead of saying the component was not found. Component name must be non-empty. Addressed PR feedback.
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* get-credential needs to activate service account * get_credential isn't activating the service account which is preventing us from obtaining credentials when run under E2E tests * the get_credential function should just be invoking get_latest_credential * Fix lint. * Fix flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
This change is