Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): UX change to support downloading directory artifacts. Fixes #3667 #4696

Merged
merged 12 commits into from
Nov 3, 2020
Merged

feat(frontend): UX change to support downloading directory artifacts. Fixes #3667 #4696

merged 12 commits into from
Nov 3, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 30, 2020 •
edited
Loading

Description of your changes:

  • Added a new UI server endpoint: /artifacts/:source/:bucket/:key, e.g. /artifacts/minio/mlpipeline/hello.tgz. This endpoint downloads artifacts without trying to extract from *.tar.gz, so it can download tar gzed directory artifacts.
  • Changed artifact url to point to new added download url.
  • When artifact preview cannot show all content, show a View All button below with original full text view url.

DEMO: https://youtu.be/IDcxRLr-kcw
Updated DEMO: https://youtu.be/iPu6v5n5onI

Checklist:

@google-cla google-cla bot added the cla: yes label Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun Ark-kun self-assigned this Oct 30, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 30, 2020

Some thoughts:

  • Gzipping is an implementation detail of Argo. We had a PR to disable this feat(backend): stop compressing artifacts #1640 The only reason we did not disable the compression yet is because there were concerns about the UX breaking. If you're fixing the UX, maybe we can make sure the uncompressed artifacts work in the UX and turn odd the compression.
  • The only case where the user might want to download a .tar.gz archive is when the artifact is a directory. This represents a minority of the artifact use-cases. Let's try to ensure the majority scenario does not degrade.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 30, 2020

Currently the "Show All" link is in the bottom. Can you show it at the top alongside the archive link? I think we do not need to show the actual archive URI.

some_output: [View] [Download] [Visualize] 37KiB
[preview]

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

Currently the "Show All" link is in the bottom. Can you show it at the top alongside the archive link? I think we do not need to show the actual archive URI.

some_output: [View] [Download] [Visualize] 37KiB
[preview]

I think the actual archive URI is still useful for cases like using GCS as the storage.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

/retest

@Bobgy Bobgy changed the title feat(frontend): change artifact link to download without extracting. Fixes #3667 feat(frontend): UX change to allow downloading directory artifacts. Fixes #3667 Nov 2, 2020
@Bobgy Bobgy changed the title feat(frontend): UX change to allow downloading directory artifacts. Fixes #3667 feat(frontend): UX change to support downloading directory artifacts. Fixes #3667 Nov 2, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 2, 2020

Hi @eterna2, do you want to review this UX change?
Feedback welcomed on the DEMO, you can decide to review code or not, there's a fair amount of them.

@eterna2
Copy link
Contributor

eterna2 commented Nov 2, 2020

Hi @eterna2, do you want to review this UX change?
Feedback welcomed on the DEMO, you can decide to review code or not, there's a fair amount of them.

Sure. I will have a look at it tomorrow.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 3, 2020

/lgtm

There seems to be a recent change where PRs started being auto-approved.
Please unhold when you are ready.
/hold

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 3, 2020

Thanks @Ark-kun! I'll wait for @eterna2's opinion before drawing a final conclusion.

eterna2
eterna2 reviewed Nov 3, 2020
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 3, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 3, 2020

Thank you for catching that @eterna2 ! Fixed the two problems

@eterna2
Copy link
Contributor

eterna2 commented Nov 3, 2020

/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 3, 2020

/unhold

@k8s-ci-robot k8s-ci-robot merged commit e3992fa into kubeflow:master Nov 3, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Bobgy @Jeffwan
feat(frontend): UX change to support downloading directory artifacts. F…
4687bab 
…ixes kubeflow#3667 (kubeflow#4696)

* feat(frontend): change artifact link to download without extracting. Fixes kubeflow#3667

* update artifact preview UX

* Fix tests

* add frontend unit tests

* fix

* move artifact integration tests to its own file

* fixed flaky aws-helper test

* refactor and add ui server integration tests

* Update UX according to feedback

* update snapshots

* Update minio-helper.ts

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eterna2 eterna2 eterna2 left review comments

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@eterna2 eterna2

@Ark-kun Ark-kun

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bobgy @k8s-ci-robot @kubeflow-bot @Ark-kun @eterna2