-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK/client] Fixes authentication refreshing mechanism #3981
Conversation
Thank you for fixing the issue. |
Thanks! Actually I think #2625 is fixed by #2626 IIUC, where refresh token is introduced. I am under the impression that refresh token should not have 1 hour TTL. @chensun can correct me if I am wrong. However if a user provide an existing token to the client I think they'll need to take care of the refreshing themselves. |
Did some manual validation at https://2ce65529ad19b245-dot-us-central2.pipelines.googleusercontent.com/#/runs/details/56535ae7-561d-4fee-8149-4f3267340d57 Seems working |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3630
Synced with @chensun , we only need this refresh for inverse proxy style authentication because
gcloud auth print-access-token
has a 1 hour TTL while in_get_auth_token()
we're using refresh token, which does not have such limit.