Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunDetails test suite, bug fixes #394

Merged
merged 5 commits into from
Nov 28, 2018
Merged

RunDetails test suite, bug fixes #394

merged 5 commits into from
Nov 28, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 27, 2018

Adds a comprehensive test suite for the RunDetails component, which caught a few bugs, also fixed here:

  • Gracefully handle missing fields on the workflow object when displaying its config fields.
  • Also parse out the selected node's message field when calling load, which is called on refresh.
  • If the message field is gone after refresh, remove the banner.
  • Wait for the side pane's busy state to be set before proceeding to unset it.

Fixes #383.


This change is Reviewable

@yebrahim
Copy link
Contributor Author

/test presubmit-e2e-test

@IronPan
Copy link
Member

IronPan commented Nov 28, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42ccde1 into master Nov 28, 2018
@yebrahim yebrahim deleted the yebrahim/run-details branch November 28, 2018 03:49
@yebrahim
Copy link
Contributor Author

Was this approved by mistake?

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* improvements to README.md

* improvements to README.md

* improvements to README.md
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Set KFservice default timeout to lower value

This is to reduce default terminationGracePeriod so that user-container
which ignore SIGTERM can be terminated more quickly
Fix kubeflow#394

* Set KFservice default timeout to 10 seconds
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
* update 0.5 release reference

* Update guides/kfp_tekton_install.md

Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RunDetails page tests
3 participants