Disables back button when there is no history #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen whenever a user opens up a page from a URL. A common way to hit this is to create a run from a notebook and click the link to see it in the UI.
8f6f7cc to
8473b06
Compare
yebrahim
reviewed
Nov 26, 2018
| </IconButton> | ||
| <div> {/* Div needed because we sometimes disable a button within a tooltip */} | ||
| <IconButton className={css.backLink} | ||
| disabled={this.props.history!.length < 2} |
There was a problem hiding this comment.
This check doesn't handle the case where the back button would take us outside of the Pipelines UI, but I don't think there's a way to handle that anyway. And maybe this behavior isn't very bad.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Upload workflow status while timeout * Fix unit tests
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
…n Task (#377) * enhance the when condition UI display * Fix UI display issue if custom task definend for Tekton Task
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #221
Previously, when users created a run from a notebook and clicked the resulting link to see it in the UI, they would see an active, clickable back button but clicking it would have no effect.
Now, when there is no browser history, the back button is still present, but it is lighter gray and has no hover animation.
This change is