Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Improve the python package build #364

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 22, 2018

  • Make the script fail on error.
  • Support relative output paths: ./build.sh kfp.tar.gz
  • Support default output path (./kfp.tar.gz): ./build.sh

This change is Reviewable

* Make the script fail on error.
* Support relative output paths: `./build.sh kfp.tar.gz`
* Support default output path (`./kfp.tar.gz`): `./build.sh`
@Ark-kun Ark-kun requested a review from qimingj November 22, 2018 02:04
@Ark-kun Ark-kun changed the title SDK - Improove the python package build SDK - Improve the python package build Nov 26, 2018
@Ark-kun Ark-kun requested a review from gaoning777 December 1, 2018 05:48
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d355a15 into master Dec 3, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK---Imporove-the-python-package-build branch January 15, 2019 22:09
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants