-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment resource version from /v1beta1 -> /v1 in gcp_marketplace #3434
Conversation
pring @rmgogogo |
/test kubeflow-pipeline-e2e-test |
Current stable release is 1.14 IIRC, which should be fine. @NikeNano Did you apply the app CRD prior to installation? |
What is it that currently is in version 1.14 IIRC? I made some updates to the CRD for the base and was asked by @rmgogogo to also update the once for gap_marketplace. I applied the CRD before installation for the base but I have note tried out the once for the market place. I used k8s 1.18 to try it out, but since it is valid from k8s 1.9 I thought it was fine to update. I am still new when it comes to K8s so might have missed something :) |
I'm introducing a PreSubmit test to well test the GCP changes and it will be submitted soon (and Prow config required). Will get back to this PR right after that one so that this PR can easily be tested. Thanks. |
Any updates on the progress @rmgogogo? |
hi Nike, please help hold this for a while as another new FR (cache) can't work well. To well isolate the problem, here let's hold this change for a while. I'm not pretty sure whether the v1 is well supported by MKP backend yet. |
Sure @rmgogogo. |
/test kubeflow-pipeline-mkp-test |
@NikeNano: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR can pass test in old MKP mpdev but can't in new. This PR itself is OK. As for the root fix for bypassing MKP mpdev, I will handle it in another thread/PR. |
/lgtm here force merge as I triggered the MKP test which can't pass now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I tried to deploy Kubeflow Pipelines but had some issues due to that the version on the deployment resource are /v1beta1 which is deprecated since 1.16. This PR suggest to fix that by updating the version.
Related to #3421