Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment resource version from /v1beta1 -> /v1 in gcp_marketplace #3434

Merged
merged 1 commit into from
May 15, 2020

Conversation

NikeNano
Copy link
Member

@NikeNano NikeNano commented Apr 3, 2020

I tried to deploy Kubeflow Pipelines but had some issues due to that the version on the deployment resource are /v1beta1 which is deprecated since 1.16. This PR suggest to fix that by updating the version.

Related to #3421

@kubeflow-bot
Copy link

This change is Reviewable

@NikeNano
Copy link
Member Author

NikeNano commented Apr 3, 2020

pring @rmgogogo

@NikeNano
Copy link
Member Author

NikeNano commented Apr 3, 2020

/test kubeflow-pipeline-e2e-test

@numerology
Copy link

Current stable release is 1.14 IIRC, which should be fine.

@NikeNano Did you apply the app CRD prior to installation?

@NikeNano
Copy link
Member Author

NikeNano commented Apr 6, 2020

Current stable release is 1.14 IIRC, which should be fine.

@NikeNano Did you apply the app CRD prior to installation?

What is it that currently is in version 1.14 IIRC?

I made some updates to the CRD for the base and was asked by @rmgogogo to also update the once for gap_marketplace. I applied the CRD before installation for the base but I have note tried out the once for the market place.

I used k8s 1.18 to try it out, but since it is valid from k8s 1.9 I thought it was fine to update. I am still new when it comes to K8s so might have missed something :)

@rmgogogo
Copy link
Contributor

rmgogogo commented Apr 7, 2020

I'm introducing a PreSubmit test to well test the GCP changes and it will be submitted soon (and Prow config required). Will get back to this PR right after that one so that this PR can easily be tested.

Thanks.

@Ark-kun Ark-kun changed the title Update deployment resource version from /v1beta1 -> /v1 gap_marketplace Update deployment resource version from /v1beta1 -> /v1 in gcp_marketplace Apr 7, 2020
@NikeNano
Copy link
Member Author

Any updates on the progress @rmgogogo?

@rmgogogo
Copy link
Contributor

hi Nike, please help hold this for a while as another new FR (cache) can't work well. To well isolate the problem, here let's hold this change for a while. I'm not pretty sure whether the v1 is well supported by MKP backend yet.

@NikeNano
Copy link
Member Author

hi Nike, please help hold this for a while as another new FR (cache) can't work well. To well isolate the problem, here let's hold this change for a while. I'm not pretty sure whether the v1 is well supported by MKP backend yet.

Sure @rmgogogo.

@rmgogogo
Copy link
Contributor

/test kubeflow-pipeline-mkp-test

@k8s-ci-robot
Copy link
Contributor

@NikeNano: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-mkp-test 4b7fe6c link /test kubeflow-pipeline-mkp-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rmgogogo
Copy link
Contributor

This PR can pass test in old MKP mpdev but can't in new. This PR itself is OK.
Here force merge this PR into repo first as the change is correct.

As for the root fix for bypassing MKP mpdev, I will handle it in another thread/PR.

@rmgogogo
Copy link
Contributor

/lgtm
/approve

here force merge as I triggered the MKP test which can't pass now.
More in b/155952507

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo rmgogogo merged commit 3d2c6ea into kubeflow:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants