Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Sagemaker : Pinned the pip packages in dockerfile #3425

Closed
wants to merge 1 commit into from

Conversation

akartsky
Copy link
Contributor

@akartsky akartsky commented Apr 2, 2020

Please merge this first : #3397

Pinned the pip packages and rearranged the dockerfile

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mameshini
You can assign the PR to them by writing /assign @mameshini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @akartsky. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akartsky akartsky changed the title Pinned the pip packages AWS Sagemaker : Pinned the pip packages Apr 2, 2020
@akartsky akartsky changed the title AWS Sagemaker : Pinned the pip packages AWS Sagemaker : Pinned the pip packages in dockerfile Apr 2, 2020
@Jeffwan
Copy link
Member

Jeffwan commented Apr 3, 2020

@akartsky Can you just add one more commit and update that PR #3397?

@akartsky
Copy link
Contributor Author

akartsky commented Apr 6, 2020

@akartsky Can you just add one more commit and update that PR #3397?

done
closing this PR

@akartsky akartsky closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants