-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manifest] Cache - Fix upgrade manifest #3338
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6994984
Initial execution cache
rui5i 1534782
Merge branch 'master' of https://github.com/kubeflow/pipelines
rui5i d5ce005
Merge branch 'master' of https://github.com/kubeflow/pipelines
rui5i fdb3ba4
fix master
rui5i 2b69c1e
Merge branch 'master' of https://github.com/kubeflow/pipelines
rui5i 6a4dca2
Merge branch 'master' of https://github.com/kubeflow/pipelines
rui5i 295f155
Merge branch 'master' of https://github.com/kubeflow/pipelines
rui5i b38e642
Change cache deployer job to stateful set
rui5i ad3fae9
Delete cache deployer job
rui5i 0d42daf
Delete cache deployer job after it completes
rui5i d2e6b8d
minor fix
rui5i c84e716
fix indention
rui5i 42ddf93
Change cache deployer job to statefulset
rui5i ee1b5e0
Remove extra cluster role for cache deployer
rui5i 7e10184
remove cache in base kustomize file for upgrade test
rui5i b7e72da
minor fix
rui5i File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
manifests/kustomize/base/cache-deployer/cache-deployer-job.yaml
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
manifests/kustomize/base/cache-deployer/cache-deployer-statefulset.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
apiVersion: apps/v1 | ||
kind: StatefulSet | ||
metadata: | ||
name: cache-deployer-statefulset | ||
labels: | ||
app: cache-deployer | ||
spec: | ||
replicas: 1 | ||
serviceName: cache-deployer | ||
selector: | ||
matchLabels: | ||
app: cache-deployer | ||
template: | ||
metadata: | ||
labels: | ||
app: cache-deployer | ||
spec: | ||
containers: | ||
- name: main | ||
image: gcr.io/ml-pipeline/cache-deployer:latest | ||
imagePullPolicy: Always | ||
env: | ||
- name: NAMESPACE_TO_WATCH | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: metadata.namespace | ||
serviceAccountName: kubeflow-pipelines-cache-deployer-sa | ||
restartPolicy: Always | ||
volumeClaimTemplates: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain the reason to restart a successfully completed deployer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StatefulSet and Deployment only support restartPolicy: Always. In this scenario the script will keep running. Seems like Job is still the most fit role. But regarding upgrade issue, is there any way we can delete the deployer-job after it finish?