Update IBM Watson ML sample to use V4 api #3274
Conversation
|
Hi @kevinyu98. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -68,73 +71,117 @@ def train(args): | |||
| "instance_id": wml_instance_id, | |||
| "apikey": wml_apikey | |||
| } | |||
| client = WatsonMachineLearningAPIClient( wml_credentials ) | |||
|
|
|||
| client = WatsonMachineLearningAPIClient ( wml_credentials ) | |||
There was a problem hiding this comment.
| client = WatsonMachineLearningAPIClient ( wml_credentials ) | |
| client = WatsonMachineLearningAPIClient(wml_credentials) |
| "training_lib_href": "/v4/libraries/"+custom_library_uid, | ||
| "compute": { | ||
| "name": "k80", | ||
| "nodes": 1 |
There was a problem hiding this comment.
Maybe add new parameters for the name and node so users can change their t-shirt size?
|
/ok-to-test |
| @@ -26,6 +26,8 @@ inputs: | |||
| - {name: run_definition, description: 'Name for the Watson Machine Learning training definition', default: 'python-tensorflow-definition'} | |||
| - {name: run_name, description: 'Name for the Watson Machine Learning training-runs', default: 'python-tensorflow-run'} | |||
| - {name: author_name, description: 'Name of this training job author', default: 'default-author'} | |||
| - {name: compute_name, description: 'Name of the compute tiers, in WML is the gpu count', default: 'k8'} | |||
| @@ -103,8 +106,8 @@ def train(args): | |||
| "command": wml_execution_command, | |||
| "training_lib_href": "/v4/libraries/"+custom_library_uid, | |||
| "compute": { | |||
| "name": "k80", | |||
| "nodes": 1 | |||
| "name": wml_runtime_version_v4, | |||
There was a problem hiding this comment.
done, pushed new image also.
|
/lgtm |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
* testing kevin-wml-iks-pipeline * switch input/output order * build v4 * fix the yaml link * change to v4 * using new v4 api * update train docker verion to v0.3 * try v4-api * try v4 author * test v4 code * fix compile error * name upcase * comment out author name * fix lowcase runtime * replace framework with platform * fix syntax platform * add version * add filepath * add file path * using wml train code as filepath * change credentials to s4 * try different version * try store_library * wml-v4 code * update image to v0.4 * change object storage type to s3 * try store with meta no * add input for store * missing comma at store yaml * add missing parameter in kfp * add argument in store * add uid * add meta type * change deploy * deployment input * list deployment * delete deployment * adjust input * play around the input data: * play around input data * change input * deploy works * fix min * clean the code * adjust serve pipeline code * clean the doc session * remove hard code * update yaml * commit stuff * test1 * change order * correct name * change version * test * change1 * change to 0,8 * print runtime version * change to 0.9 * change2 * change yaml * change version * remove command * change version * change version * clean up * address comments * fix typo
This PR contains the following updates:
train/store/deployunder ibm-component watson to use WML v4 apiwatson_train_serve_pipelineThis change is