-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add presto pipeline component #3261
add presto pipeline component #3261
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @mertkavi. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! and we'll verify it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
It seems that this component does not have any outputs. |
@Ark-kun Presto queries write a file by nature. For example, |
Even if the component creates something in an external system, it's useful to have outputs. You can output table name, object id or URI. Then a downstream component can use that to run another query or read the data. Even if something like table name comes from input it's still useful to "pass-through" and output it. This a way of establishing dependencies between tasks. |
Thank you for comment @Ark-kun I added the output. |
Are there going to be other presto-related components in the future? If so, it might be better to move the code to, say, |
/lgtm |
@mertkavi: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It makes sense. I moved it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add presto pipeline component * add output to component * move the code to organization-component folder
A Kubeflow Presto Pipeline component to submit a query to Presto.
This change is