Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TFX to 0.21.2 #3255

Merged
merged 6 commits into from
Mar 11, 2020
Merged

Bump TFX to 0.21.2 #3255

merged 6 commits into from
Mar 11, 2020

Conversation

numerology
Copy link

@numerology numerology commented Mar 10, 2020 •
edited
Loading

This is a rather complex version bumping, including following work items:

  • Bump TFX dependency in backend/test-infra
  • Bump TFMA to 0.21.5 in frontend server
  • Modernize prebuilt TFX sample by deprecating ModelValidator
  • Verify caching works
  • Verify TFMA/TFDV and TB viz with and without caching (on a dev frontend)

This change is Reviewable

@numerology
Copy link
Author

/assign @Bobgy

Yuan do you mind taking a look to see whether TFMA part is good? Thanks!

@Bobgy
Copy link
Contributor

Bobgy commented Mar 11, 2020

@numerology look at #3223 (comment)

Fixes #3223

@Bobgy Bobgy linked an issue Mar 11, 2020 that may be closed by this pull request
[Visualization] Upgrade tfma to 0.21.5 and remove the hack #3223
Closed
@numerology numerology changed the title [WIP] Bump TFX to 0.21.2 Bump TFX to 0.21.2 Mar 11, 2020
@numerology
Copy link
Author

@numerology look at #3223 (comment)

Fixes #3223

Thanks! It's working now

@numerology
Copy link
Author

/assign @neuromage

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fad7510 into kubeflow:master Mar 11, 2020
@numerology numerology deleted the bump-tfx-0212 branch March 16, 2020 17:17
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Jeffwan
Bump TFX to 0.21.2 (kubeflow#3255)
30c6a7d 
* bump tfx

* bump tfma

* modernize py sample

* clean up

* update notebook sample

* Remove tmp hack in visualization server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

Assignees

@neuromage neuromage

@Bobgy Bobgy

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Visualization] Upgrade tfma to 0.21.5 and remove the hack
4 participants
@numerology @Bobgy @neuromage @k8s-ci-robot