[Frontend] Fix the TFMA/TFDV viz behavior when caching is used. #3228
Conversation
|
/assign @Bobgy This is my first line of TS so please let me know if I'm not doing in the right way. Thanks! |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
There was a problem hiding this comment.
/approve
Thanks for trying a UI fix!
@numerology Just want to double check whether you tried these changes locally. You can follow guides in https://github.com/kubeflow/pipelines/blob/master/frontend/README.md to run a local dev server and proxy api requests to your real cluster.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Fixed the ml-metadata store image |
Thanks for the info. Will do |
|
/hold verification wip |
|
@Bobgy Did a local test. Looks good. See https://screenshot.googleplex.com/wdio46kv1P9 Thanks for the guideline! |
|
/hold cancel Verification passed. |
|
/lgtm |
…flow#3228) * include cached execution * apply suggestion * typo fix * lint * improve style * fix typo * fix
Reason:
Currently for output artifact resolution we only consider executions with COMPLETE status. However, when cache is used, the current execution with the right argo pod name will be published with CACHED status [1]. Those should also be considered.
[1] https://github.com/tensorflow/tfx/blob/29349c9bd0196af3a7c0336a5339897406cbfdb3/tfx/components/base/base_driver.py#L263
This change is