Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the magic which update codes only when building a docker image… #3188

Merged
merged 1 commit into from
Feb 28, 2020
Merged

remove the magic which update codes only when building a docker image… #3188

merged 1 commit into from
Feb 28, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 28, 2020 •
edited by jlewi
Loading

remove the magic which update codes only when building a docker image with a commit callback

This change is Reviewable

@rmgogogo
Copy link
Contributor Author

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@rmgogogo: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rmgogogo rmgogogo added the lgtm label Feb 28, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 28, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor Author

/retest

@rmgogogo
Copy link
Contributor Author

in the future we may bring similar logic in release script and submit codes (just like the part we update component commit sha)

@Bobgy
Copy link
Contributor

Bobgy commented Feb 28, 2020

in the future we may bring similar logic in release script and submit codes (just like the part we update component commit sha)

Can you put your ideas on #2721 (comment)?
We have discussed about this and all prefer not complicating release step.

@k8s-ci-robot k8s-ci-robot merged commit a6df279 into kubeflow:master Feb 28, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@rmgogogo @Jeffwan
remove the magic which update codes only when building a docker image…
a6b6424 
… with a commit callback (kubeflow#3188)

Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@sivanantha321
Fix serving runtime webhook cert namespace for kubeflow installation (k…
90be96b 
…ubeflow#3188)

* Fix serving runtime webhook cert namespace for kubeflow installation

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Generate CRD

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@Bobgy Bobgy

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmgogogo @k8s-ci-robot @Bobgy