[Frontend] Update deps to bring optional chaining js language feature #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
90b4fbe to
1a9eaab
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…kubeflow#3154) * Upgrade prettier * Optional chaining example usage * Fix eslintrc * Also upgrade typescript * pin prettier version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area frontend
/assign @Bobgy
Part of #2407
UPDATE: I cannot fix the test configs, it seems this is also blocked by #2432, because create-react-app-ts has restriction on which jest and ts-jest version to use.
UPDATE2: After #2432 fixed, also upgraded typescript, this works now.
Optional chaining example usage: https://github.com/kubeflow/pipelines/pull/3154/files#diff-1e8357336f0f74b158fbf0751ac2d9da
This change is