Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLMD][Lineage] Navigate to ArtifactDetails Overview on row click [long term] #3141

Merged
merged 3 commits into from
Feb 25, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 21, 2020

This is the long term solution mentioned in #3137.

demo: https://youtu.be/1zK8I6UzQXc

/assign @kwasi
/area frontend
/priority p0


This change is Reviewable

@Bobgy Bobgy force-pushed the fe_artifact_lineage_route branch from 75ffadf to d8f8564 Compare February 21, 2020 10:07
@Bobgy Bobgy changed the title [MLMD][Lineage] Navigate to ArtifactDetails Overview on row click [MLMD][Lineage] Navigate to ArtifactDetails Overview on row click [long term] Feb 21, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 24, 2020

/approve
@kwasi Can you lgtm if this sounds good to you?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwasi
Copy link
Contributor

kwasi commented Feb 24, 2020

This looks great! Thanks @Bobgy!

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 2e39867 into kubeflow:master Feb 25, 2020
@Bobgy Bobgy deleted the fe_artifact_lineage_route branch February 25, 2020 01:58
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…ong term] (kubeflow#3141)

* Let artifact details lineage view use a subpath

* Organize imports

* Update snapshot
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Bumping version for 0.11.1

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* add back kustomize

* Update VERSION

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants