Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to TFX demo in getting start page #3136

Merged
merged 7 commits into from
Feb 20, 2020
Merged

Conversation

numerology
Copy link

@numerology numerology commented Feb 20, 2020

Current one is still out of dated


This change is Reviewable

@numerology
Copy link
Author

/assign @SinaChavoshi
/assign @Bobgy
/assign @neuromage

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SinaChavoshi
Copy link
Contributor

will need to update the url in the test snap shot as well.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 20, 2020
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@numerology numerology merged commit 713e132 into master Feb 20, 2020
@numerology numerology deleted the numerology-patch-2 branch February 20, 2020 22:41
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [Sample] typo fix

* update README

* Update link to TFX demo in getting start page

* update version in test snapshot

* update to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants