Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Fixed dict-style type annotations #3107

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Feb 18, 2020

Refactored _data_passing.py interface to expose functions instead of dictionaries.


This change is Reviewable

Refactored `_data_passing.py` interface to expose functions instead of dictionaries.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 18, 2020

/retest

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 18, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Feb 18, 2020

/retest

@numerology
Copy link

Thanks @Ark-kun
Nit comment otherwise LGTM

@numerology
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ee3244 into kubeflow:master Feb 19, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Refactored `_data_passing.py` interface to expose functions instead of dictionaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants