Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lineage] Update kubeflow/frontend to latest hash to pick up bug bash fixes #3102

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

kwasi
Copy link
Contributor

@kwasi kwasi commented Feb 18, 2020

/hold
/area front-end
/assign @kwasi
/priority p0

Hold for kubeflow/frontend#44.

Changes

Updates version of kubeflow/frontend to pickup fix for inaccurate Lineage lines reported in the KFP bug bash.

See description in kubeflow/frontend#39 and kubeflow/frontend#44.

Deployment

https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifact_types/Examples/artifacts/2


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Feb 18, 2020

@kwasi
Thank you! the demo looks great

@kwasi
Copy link
Contributor Author

kwasi commented Feb 19, 2020

/hold cancel

Updated, merged with master, and rebuilt the image for validation. Same deployment link:

https://6d1629804d56a867-dot-us-central2.pipelines.googleusercontent.com/#/artifact_types/Examples/artifacts/2

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8524dae into kubeflow:master Feb 19, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
… fixes (kubeflow#3102)

* Bump kubeflow/frontend hash to pick up Lineage fix for inaccurate lines

* Bump to latest hash of kubeflow/frontend

* Update to latest kubeflow/frontend hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants