-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiserver: Close rows before reusing tx #3099
apiserver: Close rows before reusing tx #3099
Conversation
Hi @discordianfish. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Built and deploy it, but unfortunately still getting the same error. So this PR does not seem to have fixed the issue.. So still on it. |
Reusing tx before closing rows (might) result in the following error: [mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer This closes kubeflow#3098
9394ef3
to
a45acb5
Compare
Ok, this is fixed and ready to get merged now. |
/assign @jingzhang36 |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingzhang36 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* apiserver: Close rows before reusing tx Reusing tx before closing rows (might) result in the following error: [mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer This closes kubeflow#3098 * Add comment as requested by reviewer
Reusing tx before closing rows (might) result in the following error:
[mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer
This closes #3098
This change is