Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiserver: Close rows before reusing tx #3099

Merged

Conversation

discordianfish
Copy link
Member

@discordianfish discordianfish commented Feb 17, 2020

Reusing tx before closing rows (might) result in the following error:

[mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer

This closes #3098


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @discordianfish. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@discordianfish
Copy link
Member Author

Built and deploy it, but unfortunately still getting the same error. So this PR does not seem to have fixed the issue.. So still on it.

Reusing tx before closing rows (might) result in the following error:

[mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer

This closes kubeflow#3098
@discordianfish discordianfish force-pushed the fix-apiserver-storage-close-rows branch from 9394ef3 to a45acb5 Compare February 18, 2020 17:34
@discordianfish
Copy link
Member Author

Ok, this is fixed and ready to get merged now.
(I missed the same bug happening in DefaultExperimentStore as well)

@discordianfish
Copy link
Member Author

/assign @jingzhang36

@discordianfish
Copy link
Member Author

/ok-to-test

@jingzhang36
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingzhang36

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6ea98d3 into kubeflow:master Feb 26, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* apiserver: Close rows before reusing tx

Reusing tx before closing rows (might) result in the following error:

[mysql] 2020/02/17 11:55:38 packets.go:427: busy buffer

This closes kubeflow#3098

* Add comment as requested by reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apiserver does not close rows in InitializeDBStatusTable leading to "busy buffer" errors
3 participants