Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version of kubeflow/frontend for LineageView hotfix #2970

Closed
wants to merge 1 commit into from

Conversation

kwasi
Copy link
Contributor

@kwasi kwasi commented Feb 3, 2020

/priority p0
/area front-end
/cc @neuromage
/cc @avdaredevil
/cc @Bobgy

kubeflow/frontend@59cbf3d introduced a regression with the way resource descriptions are displayed on the Lineage View.

The regression has been fixed in kubeflow/frontend but kubeflow/pipelines needs to be bumped to pickup this fix.

I've filed an issue to add better testing to catch this issue. kubeflow/frontend#36.

This regression was missed in Pipelines because there's no test for ArtifactDetails.tsx.


This change is Reviewable

@kwasi
Copy link
Contributor Author

kwasi commented Feb 3, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@kwasi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test facd36d link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-e2e-test facd36d link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@kubeflow/frontend": "github:Bobgy/frontend#36d6d1",
"@kubeflow/frontend": "github:kubeflow/frontend#209f513",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubeflow/frontend@9023682

Can you use this instead? My fork included the two new changes.

@neuromage
Copy link
Contributor

@rmgogogo can we include this PR for the 0.2.2 release?

/cc @kwasi

@k8s-ci-robot
Copy link
Contributor

@neuromage: GitHub didn't allow me to request PR reviews from the following users: kwasi.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rmgogogo can we include this PR for the 0.2.2 release?

/cc @kwasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avdaredevil
Copy link
Contributor

There are conflicts.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avdaredevil
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avdaredevil
Copy link
Contributor

/assign @kwasi

@Bobgy
Copy link
Contributor

Bobgy commented Feb 4, 2020

/close
Already updated to latest in #2976

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closed this PR.

In response to this:

/close
Already updated to latest in #2976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants