-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the latest version of kubeflow/frontend for LineageView hotfix #2970
Conversation
/retest |
@kwasi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -3,7 +3,7 @@ | |||
"version": "0.1.0", | |||
"private": true, | |||
"dependencies": { | |||
"@kubeflow/frontend": "github:Bobgy/frontend#36d6d1", | |||
"@kubeflow/frontend": "github:kubeflow/frontend#209f513", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use this instead? My fork included the two new changes.
@neuromage: GitHub didn't allow me to request PR reviews from the following users: kwasi. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There are conflicts. /approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avdaredevil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @kwasi |
/close |
@Bobgy: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority p0
/area front-end
/cc @neuromage
/cc @avdaredevil
/cc @Bobgy
kubeflow/frontend@59cbf3d introduced a regression with the way resource descriptions are displayed on the Lineage View.
The regression has been fixed in kubeflow/frontend but kubeflow/pipelines needs to be bumped to pickup this fix.
I've filed an issue to add better testing to catch this issue. kubeflow/frontend#36.
This regression was missed in Pipelines because there's no test for
ArtifactDetails.tsx
.This change is