-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MKP] Add initializaion action for MKP deployer #2932
[MKP] Add initializaion action for MKP deployer #2932
Conversation
/hold testing |
/assign @rmgogogo |
/hold cancel |
@rmgogogo Can you confirm how to access the EnableFullScope flag? I think it'll be better if we can direct use that flag instead of infer from different error msgs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* update docker * add gcloud sdk * add gcs creation and configmap * fix lint * update docker * rename/move old deploy.sh * add permission * typo * fix random id * namespace typo * add project id * fix typo
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
in order to automatically create a bucket.
It also populate a configmap named 'gcp-default-config' for later use.
Pending manual tests.Verified auto bucket creation and configmap creation is working.
This change is