Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include experiment ID as part of run table #2929

Merged
merged 10 commits into from
Feb 5, 2020
Merged

Include experiment ID as part of run table #2929

merged 10 commits into from
Feb 5, 2020

Conversation

frozeNinK
Copy link
Contributor

@frozeNinK frozeNinK commented Jan 29, 2020 •
edited
Loading

  • Add additional ExperimentUUID column in run_details table
  • Add index on ExperimentUUID and CreatedAtInSec for better performance for ListRuns API
  • Updated corresponding unit tests
  • Include server startup check to backfill ExperimentUUID

This change is Reviewable

@frozeNinK frozeNinK requested a review from IronPan January 29, 2020 20:31
@k8s-ci-robot
Copy link
Contributor

Hi @frozeNinK. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frozeNinK frozeNinK marked this pull request as ready for review January 30, 2020 02:02
@frozeNinK
Copy link
Contributor Author

frozeNinK commented Jan 30, 2020 •
edited
Loading

Not an expert of SQL, so the auto backfill needs more attention. (only did some manual test, pls advice how to do proper local integration test)

@IronPan
Copy link
Member

IronPan commented Jan 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 30, 2020
@frozeNinK frozeNinK changed the title Include and index experiment ID as part of run table Include experiment ID as part of run table Jan 30, 2020
@IronPan
Copy link
Member

IronPan commented Feb 3, 2020

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Feb 3, 2020

/retest

@frozeNinK
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot
Copy link
Contributor

@frozeNinK: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kubeflow-pipeline-sample-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented Feb 3, 2020

/ok-to-test

@IronPan
Copy link
Member

IronPan commented Feb 3, 2020

/retest

@frozeNinK
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Feb 4, 2020

/retest

2 similar comments
@frozeNinK
Copy link
Contributor Author

/retest

@frozeNinK
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 5, 2020
@IronPan
Copy link
Member

IronPan commented Feb 5, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frozeNinK
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Feb 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ebd77a7 into kubeflow:master Feb 5, 2020
@chensun chensun mentioned this pull request Apr 16, 2020
Closed
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@frozeNinK @Jeffwan
Include experiment ID as part of run table (kubeflow#2929)
be9a466 
* Include and index experiment ID as part of run table

* * Add auto backfill

* remove unnecessary binary file

* attempt to fix bazel build

* address comments

* update new index on both ExperimentUUID + CreatedAtInSec instead of only ExperimentUUID

* add more make commands

* update make commands

* revert some changes for online build
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@sivanantha321
Decode avro cloud event (kubeflow#2929)
6b5afd7 
* Decode avro cloud event

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Decode binary cloud event

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* assert headers for avro test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

Labels
approved lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frozeNinK @k8s-ci-robot @IronPan