Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the API reference comments #2916

Merged
merged 5 commits into from
Feb 12, 2020
Merged

Updated the API reference comments #2916

merged 5 commits into from
Feb 12, 2020

Conversation

OfficePop
Copy link
Contributor

@OfficePop OfficePop commented Jan 27, 2020 •
edited by jlewi
Loading

A few changes were requested to the PR I submitted for the kubeflow website. Just replicating them on the proto files so future updates don't wipe them. The edits were already accepted in the website PR.

Related PR: 1424

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @OfficePop. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Feb 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 811af38 into kubeflow:master Feb 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@OfficePop @Jeffwan
Updated the API reference comments (kubeflow#2916)
f7f795f 
* Update comments with requested edits

* Update comments with requested edits
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@henrysecond1
Reconcile when rollout duration is changed (kubeflow#2916)
6c1e7d1 
* Reconcile when rollout duration is changed

Signed-off-by: jeongwook-park <jeongwook.park@navercorp.com>

* Reconcile managed ksvc annotations

Signed-off-by: jeongwook-park <jeongwook.park@navercorp.com>

* Correctly compare annotations

Signed-off-by: jeongwook-park <jeongwook.park@navercorp.com>

---------

Signed-off-by: jeongwook-park <jeongwook.park@navercorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OfficePop @k8s-ci-robot @IronPan