Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have custom visualization on by default #2891

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Jan 22, 2020

This change is Reviewable

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy
/cc @neuromage

@Bobgy
Copy link
Contributor

Bobgy commented Jan 22, 2020

/lgtm
/approve

@jingzhang36
Copy link
Contributor Author

/assign @rmgogogo

@rmgogogo
Copy link
Contributor

how about add it as predefined type to avoid customization?
https://github.com/kubeflow/pipelines/tree/master/backend/src/apiserver/visualization/types

worried about the possible bad codes which may trigger big issue (e.x. deleted data).

@IronPan

@rmgogogo
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b20b85c into kubeflow:master Jan 22, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Have custom visualization on by default

* Add flag to gcp market
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants