Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage reporting for frontend server #2877

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jan 20, 2020

This is part of #2215

Some investigation:
Ideally, I'd want to merge both coverage reports into one report in coveralls: https://docs.coveralls.io/parallel-build-webhook, but it's not well supported for now: nickmerwin/node-coveralls#134.

Decided to not try to fix that, this simply submits two entries for each build.

/area frontend
/assign @Bobgy


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jan 20, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy added the lgtm label Jan 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4f20e85 into kubeflow:master Jan 20, 2020
@Bobgy Bobgy deleted the fe_server_coverage branch January 20, 2020 07:51
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Rylan <rylan_hazelton@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants