Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy] Split domain name #2851

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Conversation

numerology
Copy link

@numerology numerology commented Jan 15, 2020

Get a dedicated subdomain name
Test endpoint is working at https://3b55c042b138bf86-dot-us-central2.pipelines.googleusercontent.com/#/pipelines

The new config is at https://storage.googleapis.com/ml-pipeline/proxy-agent-config.json


This change is Reviewable

…plit-domain-name

� Conflicts:
�	manifests/kustomize/base/kustomization.yaml
�	manifests/kustomize/namespaced-install.yaml
@numerology numerology changed the title [WIP] Split domain name [Proxy] Split domain name Jan 15, 2020
@numerology
Copy link
Author

/assign @IronPan

Do you have any good advise in where to put the config file? I think the best practice is to factor out the 'greatest common divisor' but currently I made a separate copy.

@IronPan
Copy link
Member

IronPan commented Jan 15, 2020

Is it possible in the original config file to have

"agent-docker-containers": {
    "latest": {...}
    "pipelines": {...}
}

@numerology
Copy link
Author

Is it possible in the original config file to have

"agent-docker-containers": {
    "latest": {...}
    "pipelines": {...}
}

Good call. We will need to request datalab team to do that

@rmgogogo
Copy link
Contributor

Thanks Jiaxiao.

/lgtm

@IronPan
Copy link
Member

IronPan commented Jan 16, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

/retest

1 similar comment
@numerology
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bbf6147 into kubeflow:master Jan 16, 2020
@numerology numerology deleted the split-domain-name branch January 16, 2020 22:07
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* update config

* update manifest to test

* clean proxy deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants