-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proxy] Split domain name #2851
Conversation
…plit-domain-name � Conflicts: � manifests/kustomize/base/kustomization.yaml � manifests/kustomize/namespaced-install.yaml
/assign @IronPan Do you have any good advise in where to put the config file? I think the best practice is to factor out the 'greatest common divisor' but currently I made a separate copy. |
Is it possible in the original config file to have
|
Good call. We will need to request datalab team to do that |
Thanks Jiaxiao. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
* update config * update manifest to test * clean proxy deployment
Get a dedicated subdomain name
Test endpoint is working at https://3b55c042b138bf86-dot-us-central2.pipelines.googleusercontent.com/#/pipelines
The new config is at https://storage.googleapis.com/ml-pipeline/proxy-agent-config.json
This change is