Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend tensorboard spec #283

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Update frontend tensorboard spec #283

merged 1 commit into from
Nov 16, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 15, 2018

  • Use generateName instead of name
  • remove selector

This change is Reviewable

- Use generateName instead of name
- remove selector
@IronPan
Copy link
Member Author

IronPan commented Nov 15, 2018

/assign @yebrahim @rileyjbauer

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Nov 15, 2018

/test presubmit-e2e-test

1 similar comment
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 16, 2018

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 24d69cb into master Nov 16, 2018
@IronPan IronPan deleted the IronPan-patch-5 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
… workflows (kubeflow#283)

* Also upgrade ksonnet app to 0.3.0

* Related to kubeflow#53 GC old Argo workflows.
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants