Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min and max lines for displaying json editor #2752

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

fenglixa
Copy link
Member

@fenglixa fenglixa commented Dec 18, 2019

Fixes #2713
Add min and max lines defining for json editor, instead of hardcode height(300px)

UT PASS, Append my UT result here:

3 lines json display as below after my fix:
image

muilt-lines json display as below after my fix:

Screen Shot 2019-12-18 at 9 57 37 PM


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fenglixa
Copy link
Member Author

/cc @Bobgy could you help review, comments?

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this!
/ok-to-test

@Bobgy
Copy link
Contributor

Bobgy commented Dec 18, 2019

You need to run npm test and update changed snapshots

@fenglixa
Copy link
Member Author

fenglixa commented Dec 19, 2019

Thanks @Bobgy, Understand, updated just now. : )
Test should be PASS now:
image

@Bobgy
Copy link
Contributor

Bobgy commented Dec 21, 2019

Great! Thanks for your contribution!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1285fd9 into kubeflow:master Dec 21, 2019
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* canary and performance testing samples

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>

* scikit-learn name fix

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>

---------

Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waste of UI real estate on a run's "config" tab
3 participants