TFjob v1 launcher #2677
TFjob v1 launcher #2677
Conversation
|
|
||
| ENV TRAINER_IMAGE_NAME $TRAINER_IMAGE_NAME | ||
| RUN apt-get update -y && \ | ||
| apt-get install --no-install-recommends -y -q ca-certificates python-dev python-setuptools wget && \ |
There was a problem hiding this comment.
We should probably switch to python3 at some point.
| args.namespace, args.name, expected_conditions, | ||
| timeout=datetime.timedelta(minutes=args.tfjobTimeoutMinutes)) | ||
| if args.deleteAfterDone: | ||
| tfjob.delete(args.name, args.namespace) |
There was a problem hiding this comment.
It might be a good idea to keep the indent the same throughout the file. 4 spaces seems to be the Python's preferred style.
|
A general question (for a future PR): How hard would it be to install TFJob CR on-demand if it's missing? |
|
/retest |
| tfjobTimeoutMinutes=60, | ||
| deleteAfterDone=False): | ||
| tfjob_launcher_op = components.load_component_from_file("./component.yaml") | ||
| # tfjob_launcher_op = components.load_component_from_url('https://raw.githubusercontent.com/kubeflow/pipelines/master/components/kubeflow/launcher/component.yaml') |
There was a problem hiding this comment.
JFYI, the link already exists (use your commit hash instead of master).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ow#2677) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.0.1 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.0.1...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This change is