Add readable step id for test cloudbuild steps #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Maybe we can put the IDs first, to increase readability even more. |
|
@Ark-kun It would be great if we can do that. Do you have any ideas? |
Just change - name: "gcr.io/cloud-builders/docker"
id: "persistenceagent"
args:
["build", "-t", "$_GCR_BASE/persistenceagent", "-f", "backend/Dockerfile.persistenceagent", "."]
waitFor: ["-"]to - id: "persistenceagent"
name: "gcr.io/cloud-builders/docker"
args:
["build", "-t", "$_GCR_BASE/persistenceagent", "-f", "backend/Dockerfile.persistenceagent", "."]
waitFor: ["-"] |
|
@Ark-kun thanks, I didn't realize you meant readability of this yaml file. SGTM |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* replace table logger with tabulate Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * remove numpy<1.24.0 constraint Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * loosen protobuf dependency Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make reading cloudbuild error message a lot easier
Build log looks like the following now, it's clear which step is building which image
This change is