-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK - Python support for arbitrary secret, similar to ".use_gcp_secret('user-gcp-sa')" #2639
Conversation
Hi @NikeNano. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @NikeNano ! |
/lgtm |
/lgtm |
Last request: |
Sure will do! Happy to later make a new PR and move the other files as well if "at some point" is not in the distant future :) |
/retest |
Import error, fixing it :). Will update when i have fixed it. |
Believe it should be fixed now. Had to also update the build file. I will check the tests later. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi,
This PR is related to how to add secrets to Kubeflow containers operations in the python SDK. There are functionality for adding the GCP secrets but often other secrets needs to be added as well.
I believe this would be useful for others and therefore made this PR :)
Happy for feedback!
This change is