-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDez patch 2 #2635
MDez patch 2 #2635
Conversation
Syncing fork
Added comments to describe endpoints.
Add spacing
Hi @OfficePop. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @OfficePop. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com> Signed-off-by: Jagadeesh J <jagadeeshj@ideas2it.com>
Adding to my previous edits to the api operations, here are more of the same. I couldn't find the
/apis/v1beta1/pipelines/upload
as it didn't seem to in any of the proto files. Possibly in thego_http_client
folder instead, if that's where swagger generates it from let me know and i'll add a comment there too.This change is