Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error tfjob definition #2597

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Nov 13, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 13, 2019

/lgtm

@hougangliu
Copy link
Member Author

@Ark-kun can we merge this PR? I think the change is little.

@numerology
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0a873a9 into kubeflow:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants