Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverse-proxy test cloudbuild yaml #2568

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 7, 2019

This dockerfile assumes it is called in its containing dir as workspace. It's different from most other dockerfiles which assumes project root.

/assign @rmgogogo


This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

/test kubeflow-pipeline-sample-test

@rmgogogo
Copy link
Contributor

rmgogogo commented Nov 7, 2019

/lgtm

thanks

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 7, 2019

Bug in this PR is fixed indeed, but there's a further error.
Log:

+++ dirname /opt/proxy/attempt-register-vm-on-proxy.sh
++ cd /opt/proxy
++ pwd
+ DIR=/opt/proxy
+ kubectl get configmap inverse-proxy-config
NAME                   DATA   AGE
inverse-proxy-config   3      45s
++ jq -r .data.ProxyUrl
++ kubectl get configmap inverse-proxy-config -o json
+ PROXY_URL=https://datalab-us-east1.cloud.google.com/tun/m/4592f092208ecc84946b8f8f8016274df1b36a14
++ kubectl get configmap inverse-proxy-config -o json
++ jq -r .data.BackendId
+ BACKEND_ID=
+ run-proxy-agent
+ /opt/bin/proxy-forwarding-agent --debug=false --proxy=https://datalab-us-east1.cloud.google.com/tun/m/4592f092208ecc84946b8f8f8016274df1b36a14 --proxy-timeout=60s --backend= --host=10.67.241.223:80 --shim-websockets=true --shim-path=websocket-shim --health-check-path=/ --health-check-interval-seconds=0 --health-check-unhealthy-threshold=2
2019/11/07 15:36:27 You must specify a backend ID

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 8, 2019

The new error seems to be transient, it no longer happens now. I'll keep an eye on if that's flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants