Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Replace deprecated KubeflowRunner in TFX sample #2499

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

numerology
Copy link

@numerology numerology commented Oct 26, 2019

to prevent confusion like #2475


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 27, 2019

What are the main differences?
/lgtm

@numerology
Copy link
Author

What are the main differences?
/lgtm

KubeflowRunner is just a deprecated alias for KubeflowDagRunner. There's no functional differences AFAIK

@numerology
Copy link
Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8998087 into kubeflow:master Oct 27, 2019
@numerology numerology deleted the fix-old-tfx-oss-sample branch October 27, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants