[MKP] Fix metadata DB configmap #2491
Conversation
# Conflicts: # manifests/gcp_marketplace/guide.md
| @@ -138,3 +138,5 @@ data: | |||
| {{ end }} | |||
| mysql_host: "mysql" | |||
| mysql_port: "3306" | |||
| username: "root" | |||
| password: "" | |||
There was a problem hiding this comment.
just aware it doesn't support managed storage but it's OK for now.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -138,3 +138,5 @@ data: | |||
| {{ end }} | |||
| mysql_host: "mysql" | |||
| mysql_port: "3306" | |||
| username: "root" | |||
There was a problem hiding this comment.
Do you know why pipeline standalone deployment works?
https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/base/metadata/metadata-configmap.yaml#L8
There was a problem hiding this comment.
from @numerology lightweight uses secret to store username/pwd which makes sense.
https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/base/metadata/metadata-mysql-secret.yaml
I'm ok either we merge this in and use secret in subsequent pr or change in this pr.
* Fix kserve annotation constants ref https://knative.dev/docs/serving/autoscaling/scale-bounds/ Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Update tests with new annotations Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Two fields are missing right now.
This change is