[Frontend] Check format in travis CI #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/test kubeflow-pipeline-sample-test |
|
/approve |
|
Is it possible to include some an IDE config, so that IDEs like VS Code automatically formatted the code? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Ark-kun Already checked in, see https://github.com/kubeflow/pipelines/blob/master/frontend/README.md#code-style |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Fix grpc is not working with logger (kubeflow#2251) * Fix grpc inference request fails when used with logger. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added e2e for grpc with logger Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Fixed lint errors Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Added logs to debug failing grpc in workflow Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Made changes in e2e to use grpc with logger using torchserve Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> added grpc trace for debugging Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Made changes to move logger grpc test from torchserve to the custom model Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed lint errors Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Cleanup debug changes Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Made changes to fix review suggestions Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an error message like the following if test failed
/area front-end
/kind code-quality
This change is