Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the core libraries for diagnose_me tool. #2417

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Oct 16, 2019

RFC - specially let me know if this seems like a good location. This PR only contains the core libraries will follow up with the cli runner and additional libraries in a separate PR


This change is Reviewable

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to add CLI hooks in another PR? Will it require KFP package to add additional dependencies?

@SinaChavoshi
Copy link
Contributor Author

SinaChavoshi commented Oct 16, 2019

Are you going to add CLI hooks in another PR?

Yes, I will be submitting that under a separate PR.

Will it require KFP package to add additional dependencies?

Not at this point. However in future it may if we switch to using google cloud APIs.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 18, 2019

/lgtm

@hongye-sun
Copy link
Contributor

/lgtm

@SinaChavoshi
Copy link
Contributor Author

/assign @Ark-kun

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 22, 2019
@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 23, 2019

@googlebot I fixed it.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 24, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7edeca1 into kubeflow:master Oct 24, 2019
@SinaChavoshi SinaChavoshi deleted the diagnose_me branch November 4, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants