-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the core libraries for diagnose_me tool. #2417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to add CLI hooks in another PR? Will it require KFP package to add additional dependencies?
Yes, I will be submitting that under a separate PR.
Not at this point. However in future it may if we switch to using google cloud APIs. |
/lgtm |
/lgtm |
/assign @Ark-kun |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
0450149
to
f30cad2
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RFC - specially let me know if this seems like a good location. This PR only contains the core libraries will follow up with the cli runner and additional libraries in a separate PR
This change is