Update samples/core/tfx-oss to tfx==0.14.0 and kfp=0.1.31 #2385
Conversation
|
Hi @ucdmkt. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| pip3 install tfx==0.13.0 --upgrade | ||
| pip3 install kfp --upgrade | ||
| pip3 install 'tfx==0.14.0' --upgrade | ||
| pip3 install 'kfp>=0.1.31' --upgrade |
There was a problem hiding this comment.
Should it be 'kfp>=0.1.31.2'?
There was a problem hiding this comment.
The compatibility issue in TFX's KubeflowDagRunne was only for test (which is fixed anyways tensorflow/tfx@ea85bfe#diff-642c05352d80030caf1d9d3fe41f9740), but there was no compatibility issue in orchestrator itself.
Is there any other reason to prefer 0.1.31.2 or higher?
There was a problem hiding this comment.
0.1.31.2 is just the current latest version.
Usually the latest version is the best, containing all the bug fixes.
The 0.1.32 will be released tomorrow which will have some more fixes.
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Also pulled utils/taxi_utils.py from 0.14.0 release
https://raw.githubusercontent.com/tensorflow/tfx/0.14.0/tfx/examples/chicago_taxi_pipeline/taxi_utils.py
This change is