Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix copying log when scrolling. #2358

Closed
wants to merge 1 commit into from
Closed

[WIP] Fix copying log when scrolling. #2358

wants to merge 1 commit into from

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Oct 10, 2019 •
edited
Loading

Fixes #1508

This is a Proof of Concept.
Discussion about this solution: #1508 (comment)

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title Fix copying log when scrolling. [WIP] Fix copying log when scrolling. Oct 10, 2019
@rmgogogo
Copy link
Contributor

/lgtm
Not familar with the codes yet but LGTM as long as your local test can work

@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 11, 2019

superceded by #2370

@Bobgy Bobgy closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

Assignees

@rmgogogo rmgogogo

Labels
do-not-merge/work-in-progress lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs are effectively impossible to copy when the log window has scroll-bar
3 participants
@Bobgy @k8s-ci-robot @rmgogogo